Skip to content

Don't take the length of None #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Don't take the length of None #91

wants to merge 9 commits into from

Conversation

j3pic
Copy link

@j3pic j3pic commented Dec 4, 2019

Should fix #86

@j3pic
Copy link
Author

j3pic commented Dec 5, 2019

I just realized you have those .c files committed to the repo instead of generating them in the build. I have no idea how to compile .pyx to C.

@j3pic
Copy link
Author

j3pic commented Dec 5, 2019

I have confirmed that it's possible to call userauth_publickey_frommemory with None for the host key.

@j3pic j3pic mentioned this pull request Dec 19, 2019
Closed
@kdart-brt
Copy link

The maintainer seems to have disappeared. Should we fork it?

@pkittenis
Copy link
Member

Thanks for the PR. This needs a short test to confirm functionality.

@pkittenis
Copy link
Member

Done by #104

@pkittenis pkittenis closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssh2.session.Session.userauth_publickey_frommemory() - TypeError: object of type 'NoneType' has no len()
3 participants
@j3pic @kdart-brt @pkittenis